Add rate limiting for scrape config updates #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
feat/ta/update-rate-limit
branch
4 times, most recently
from
6a998ce to
fce41e0
Compare
pavolloffay
approved these changes
Oct 9, 2023
jaronoff97
approved these changes
Oct 10, 2023
|
@swiatekm-sumo were you able to test this in a cluster? I'd love to see some metrics about how this change affected usage. |
I did a basic smoke test, but I didn't try any synthetic stress test where I'd constantly update a bunch of ServiceMonitors and look at TA CPU usage. I can do that and post some numbers if you're interested. |
|
yeah i'd appreciate that if you don't mind :) |
swiatekm
force-pushed
the
feat/ta/update-rate-limit
branch
from
fce41e0 to
173ad39
Compare
|
@jaronoff97 Did a very simple benchmark where I updated the labels on a particular ServiceMonitor as fast as I could via kubectl. Pre-change this used 400m worth of CPU, post change, less than 2m. See attached Prometheus graph: |
frzifus
reviewed
Oct 15, 2023
Co-authored-by: Ben B. <[email protected]>
swiatekm
force-pushed
the
feat/ta/update-rate-limit
branch
from
82dd785 to
ee8b2cb
Compare
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add rate limiting for scrape config updates * Rename constant to lowercase Co-authored-by: Ben B. <[email protected]> --------- Co-authored-by: Ben B. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the rate on updates to scrape configs. The idea and code are very similar to what Prometheus' Service Discovery manager does: https://github.com/prometheus/prometheus/blob/79be1b835789d7c3fde2a907003a8799c308733f/discovery/manager.go#L341. The end result is that we emit events about changes to Prometheus CRs at most every 5 seconds.
This should help with #1544